Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Add VoteTracker for tracking cluster's votes in gossip#8327

Merged
carllin merged 16 commits intosolana-labs:masterfrom
carllin:FixRepair2
Mar 10, 2020
Merged

Add VoteTracker for tracking cluster's votes in gossip#8327
carllin merged 16 commits intosolana-labs:masterfrom
carllin:FixRepair2

Conversation

@carllin
Copy link
Copy Markdown
Contributor

@carllin carllin commented Feb 19, 2020

Problem

No way to track which validators have voted for which slots in gossip

Summary of Changes

Add a VoteTracker in a listener service that monitors gossip to track the votes per slot.

Relies on vote_state updates in: #8303
Fixes #

@carllin carllin added the v0.23 label Feb 19, 2020
@carllin carllin requested a review from sagar-solana February 19, 2020 09:09
@mvines mvines added the v1.0 label Feb 22, 2020
@carllin carllin force-pushed the FixRepair2 branch 3 times, most recently from 94be3ff to 5dc5e6d Compare February 26, 2020 20:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2020

Codecov Report

Merging #8327 into master will increase coverage by 0.0%.
The diff coverage is 85.3%.

@@           Coverage Diff           @@
##           master   #8327    +/-   ##
=======================================
  Coverage    79.9%   79.9%            
=======================================
  Files         261     261            
  Lines       56572   57070   +498     
=======================================
+ Hits        45222   45650   +428     
- Misses      11350   11420    +70     

@carllin carllin force-pushed the FixRepair2 branch 5 times, most recently from 91f7f9e to df9d1ef Compare March 3, 2020 10:33
@mvines mvines removed the v0.23 label Mar 3, 2020
@carllin carllin force-pushed the FixRepair2 branch 11 times, most recently from 792b1a8 to a02eaf3 Compare March 6, 2020 23:36
@carllin carllin merged commit 9872430 into solana-labs:master Mar 10, 2020
mergify Bot pushed a commit that referenced this pull request Mar 10, 2020
Track votes by slot in cluster_vote_listener

(cherry picked from commit 9872430)

# Conflicts:
#	runtime/src/message_processor.rs
carllin added a commit that referenced this pull request Mar 11, 2020
Track votes by slot in cluster_vote_listener

(cherry picked from commit 9872430)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants