This repository was archived by the owner on Jan 22, 2025. It is now read-only.

CLI: Remote wallet signing#8318

Closed

t-nelson wants to merge 32 commits into

solana-labs:masterfrom

t-nelson:cli-remote-wallet-signing

Commits on Feb 18, 2020

Add generate_keypair_util helper

Tyera Eulberg
authored and
t-nelson
committed
Update slices of keypair refs to slices of trait obj refs

Tyera Eulberg
authored and
t-nelson
committed
Cli: impl config.keypair as a trait object

Tyera Eulberg
authored and
t-nelson
committed
Clean up compiler complaints

Tyera Eulberg
authored and
t-nelson
committed
*fixup* - Add generate_keypair_util helper
t-nelson
committed
SDK: Add Debug and PartialEq for Box<dyn KeypairUtil>
t-nelson
committed
ClapUtils: Arg parsing from pubkey+signers to Presigner
t-nelson
committed
CLI: Add helper for getting signers from args
t-nelson
committed
CLI: Replace SigningAuthority with KeypairUtil trait-objs
t-nelson
committed
Update more &KeypairUtil to trait-objs
t-nelson
committed
CLI: Allow derived address account creation
t-nelson
committed
CLI: Drop disused signers command field
t-nelson
committed
CLI: Drop redundant tests
t-nelson
committed
No unwrap; not all signers may exist

Tyera Eulberg
authored and
t-nelson
committed
cargo fmt

Tyera Eulberg
authored and
t-nelson
committed
Add clap validator that handles all current signer types

Tyera Eulberg
authored and
t-nelson
committed
Don't panic

Tyera Eulberg
authored and
t-nelson
committed
clap_utils: Factor Presigner resolution to helper
t-nelson
committed
SDK: `From` for boxing KeypairUtil implementors to trait objects
t-nelson
committed
SDK: Derive `Clone` for `Presigner`
t-nelson
committed
CLI: Fix tests No. 1
t-nelson
committed
Cli: dedup signers in transfer for remote-wallet ergonomics

Tyera Eulberg
authored and
t-nelson
committed
Revert "CLI: Allow derived address account creation"
t-nelson
committed
Work around `CliConfig`'s signer not necessarily being a `Keypair`
t-nelson
committed
CLI: Fix tests No. 2
t-nelson
committed
Make signers_from_matches consistent with other parsers

Tyera Eulberg
authored and
t-nelson
committed
Fix tests No. 3
t-nelson
committed
Fixup path handling (clippy)

Tyera Eulberg
authored and
t-nelson
committed
Update docs vis-a-vis ASK changes

Tyera Eulberg
authored and
t-nelson
committed
Fixup default keypair path
Tyera Eulberg
committed
Fixup bench build
t-nelson
committed
Fixup libraypay build
Tyera Eulberg
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLI: Remote wallet signing#8318

CLI: Remote wallet signing#8318
t-nelson wants to merge 32 commits into
solana-labs:masterfrom
t-nelson:cli-remote-wallet-signing

Commits on Feb 18, 2020

Add generate_keypair_util helper

Update slices of keypair refs to slices of trait obj refs

Cli: impl config.keypair as a trait object

Clean up compiler complaints

fixup - Add generate_keypair_util helper

SDK: Add Debug and PartialEq for Box<dyn KeypairUtil>

ClapUtils: Arg parsing from pubkey+signers to Presigner

CLI: Add helper for getting signers from args

CLI: Replace SigningAuthority with KeypairUtil trait-objs

Update more &KeypairUtil to trait-objs

CLI: Allow derived address account creation

CLI: Drop disused signers command field

CLI: Drop redundant tests

No unwrap; not all signers may exist

cargo fmt

Add clap validator that handles all current signer types

Don't panic

clap_utils: Factor Presigner resolution to helper

SDK: `From` for boxing KeypairUtil implementors to trait objects

SDK: Derive `Clone` for `Presigner`

CLI: Fix tests No. 1

Cli: dedup signers in transfer for remote-wallet ergonomics

Revert "CLI: Allow derived address account creation"

Work around `CliConfig`'s signer not necessarily being a `Keypair`

CLI: Fix tests No. 2

Make signers_from_matches consistent with other parsers

Fix tests No. 3

Fixup path handling (clippy)

Update docs vis-a-vis ASK changes

Fixup default keypair path

Fixup bench build

Fixup libraypay build