This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add snapshot account state verify proposal#8043
Closed
sakridge wants to merge 1 commit intosolana-labs:masterfrom
Closed
Add snapshot account state verify proposal#8043sakridge wants to merge 1 commit intosolana-labs:masterfrom
sakridge wants to merge 1 commit intosolana-labs:masterfrom
Conversation
sakridge
force-pushed
the
snapshot-accumulator-proposal
branch
from
a807e57 to
0256346
Compare
aeyakovenko
reviewed
Jan 30, 2020
aeyakovenko
reviewed
Jan 30, 2020
sakridge
force-pushed
the
snapshot-accumulator-proposal
branch
from
0256346 to
cd69a9d
Compare
t-nelson
approved these changes
Feb 3, 2020
Contributor
t-nelson
left a comment
t-nelson
left a comment
There was a problem hiding this comment.
Just a couple nits here. LGTM otherwise!
Also mind linking to references at the end? Presumably at least https://eprint.iacr.org/2018/1188.pdf
| ## Problem | ||
|
|
||
| Snapshot verification of the account states is implemented, but the bank hash of the snapshot which is used to verify is falsifiable. | ||
| When a validator boots up from a snapshot, it needs a way to verify the account set matches what the rest of the network sees quickly. A potential |
| That hash is added to an RSA accumulator in standard `g^(hash) mod n` way. | ||
|
|
||
| Since adding to an accumulator is a single-threaded process, multiple accumulators can | ||
| be used to obtain parallelism for the entire account set in the slot. They can be indexed some |
ryoqun
reviewed
Feb 3, 2020
| * Account data | ||
| * Account pubkey | ||
| * Account lamports balance | ||
| * Fork the account is stored on |
Contributor
There was a problem hiding this comment.
nits: Slot (rename remnant?)
Contributor
There was a problem hiding this comment.
nits: Also these days, hash includes rent_epoch and executable #7415
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
Bot
added
the
stale
|
This stale pull request has been automatically closed. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
xor method of rolling up hashes of live account states is too easily attacked by probabilistic collision.
Summary of Changes
Add proposal to add account states to two sets of accumulators to be able to validate the account set in a snapshot matches what is on the network.
Fixes #