This repository was archived by the owner on Jan 22, 2025. It is now read-only.
CLI: Support offline authorities#7905
Merged
t-nelson merged 1 commit intosolana-labs:masterfrom Jan 22, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7905 +/- ##
========================================
+ Coverage 81.8% 81.8% +<.1%
========================================
Files 244 244
Lines 52136 52267 +131
========================================
+ Hits 42691 42806 +115
- Misses 9445 9461 +16 |
jstarry
approved these changes
Jan 22, 2020
mergify Bot
pushed a commit
that referenced
this pull request
Jan 22, 2020
(cherry picked from commit d854e90)
solana-grimes
pushed a commit
that referenced
this pull request
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CLI
--*-authorityargs only accept aKeypairlimiting them to online authoritiesSummary of Changes
Allow
--*-authorityto accept aPubkeyif there is a matching--signer BASE58_PUBKEY=BASE58_SIGNATUREpassed alsoThis is a stop gap to a more thorough (and intrusive) implementation as described here