Update http crate to fix security vulnerability #7725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7725 +/- ##
========================================
- Coverage 81.8% 81.8% -0.1%
========================================
Files 241 238 -3
Lines 50496 50469 -27
========================================
- Hits 41326 41288 -38
- Misses 9170 9181 +11 |
This was referenced Jan 9, 2020
ryoqun
approved these changes
Jan 9, 2020
| @@ -1427,7 +1427,7 @@ dependencies = [ | |||
|
|
|||
| [[package]] | |||
| name = "http" | |||
| version = "0.1.18" | |||
| version = "0.1.21" | |||
There was a problem hiding this comment.
I double-checked this new version is actually not vulnerable anymore: hyperium/http@v0.1.18...v0.1.21
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2020
* Update http to fix security vulnerability * Ignore RUSTSEC because they incorrectly says http 0.1.21 is vulnerable (cherry picked from commit 719785a) # Conflicts: # Cargo.lock # ci/test-checks.sh
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2020
* Update http to fix security vulnerability * Ignore RUSTSEC because they incorrectly says http 0.1.21 is vulnerable (cherry picked from commit 719785a) # Conflicts: # Cargo.lock
solana-grimes
pushed a commit
that referenced
this pull request
Jan 9, 2020
solana-grimes
pushed a commit
that referenced
this pull request
Jan 9, 2020
sakridge
pushed a commit
to sakridge/solana
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
httpcrate has a vulnerability: https://rustsec.org/advisories/RUSTSEC-2019-0033CI: https://buildkite.com/solana-labs/solana/builds/17380#b9016fbc-60c3-4d70-b2df-cde028e642c6
Summary of Changes
httpcrate to 0.1.21 to pick up this change: fix capacity overflows in HeaderMap::reserve hyperium/http#360