This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix AppendVec test breakage...#7693
Merged
ryoqun merged 1 commit intosolana-labs:masterfrom Jan 7, 2020
Merged
Conversation
ryoqun
commented
Jan 6, 2020
| } | ||
|
|
||
| #[test] | ||
| fn test_set_file_empty_data() { |
Contributor
Author
There was a problem hiding this comment.
ryoqun
commented
Jan 7, 2020
| let file = get_append_vec_path("test_append_vec_set_file_bad_size"); | ||
| let path = &file.path; | ||
| let mut av = AppendVec::new_empty_map(0); | ||
| assert_eq!(av.accounts(0).len(), 0); |
Contributor
Author
There was a problem hiding this comment.
Carry over only this assertion from now unified test: https://github.com/solana-labs/solana/pull/7693/files#diff-657d1e7648a9fb74cb1582a9c48beb4bR566
Contributor
Author
|
What... never seen ci error...: |
Contributor
Author
|
Although stable failed for mysterious and unrelated reason, coverage build succeeded. :) I'm merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7373 started to break master branch's CI.. This is caused by incompatible changes introduced by my parallel PR #7464. They are met with each other for the first time on the master branch..