This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Check for incorrect hash value on snapshot ingest#7427
Closed
sakridge wants to merge 1 commit intosolana-labs:masterfrom
Closed
Check for incorrect hash value on snapshot ingest#7427sakridge wants to merge 1 commit intosolana-labs:masterfrom
sakridge wants to merge 1 commit intosolana-labs:masterfrom
Conversation
Contributor
Author
|
@ryoqun can you take over this PR actually? |
sakridge
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7427 +/- ##
========================================
- Coverage 80.6% 74.8% -5.8%
========================================
Files 245 245
Lines 48439 52168 +3729
========================================
- Hits 39048 39047 -1
- Misses 9391 13121 +3730 |
Contributor
Yeah, I'll add a unit test and review you back. :) |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No checking on snapshot ingestion that data which is hashed matches the hash value in the append vec.
Summary of Changes
Re-hash the account data and check for differences.
Part of #7167
Fixes #