Only serialize rooted append vecs

[sakridge]

Problem

Slots which are not rooted could end up in a snapshot and cause account mismatch issues since we mark each present slot as rooted when we ingest the snapshot.

Summary of Changes

Only add rooted append-vecs to the snapshot, for now skip any failures when we load the snapshot if an appendvec is in the index but not present as a file.

• skipping the file on failure is not great, but when we serialize the storage entries, we don't know which slots are rooted. Find a better solution for that.

Fixes #7244

[sakridge]

@ryoqun this is just kind of a guess, let me look at your snapshot file, those accounts should be present in the older fork as well for this to make sense.

[ryoqun]

@ryoqun this is just kind of a guess, let me look at your snapshot file, those accounts should be present in the older fork as well for this to make sense.

@sakridge Sure! I've uploaded here Could you use this to confirm?

[codecov]

Codecov Report

Merging #7281 into master will decrease coverage by 4.5%.
The diff coverage is 77%.

@@           Coverage Diff            @@
##           master   #7281     +/-   ##
========================================
- Coverage    73.2%   68.6%   -4.6%     
========================================
  Files         240     237      -3     
  Lines       50234   52368   +2134     
========================================
- Hits        36800   35965    -835     
- Misses      13434   16403   +2969

[ryoqun]

Just viewed the code. Really thanks for proposing PRs quickly once after I find the bugs!! The impl code looks nice for now.

Only add rooted append-vecs to the snapshot, for now skip any failures when we load the snapshot if an appendvec is in the index but not present as a file.

As you said, this might not be elegant, but it'll work. Maybe put empty files in place for skipped AppendVecs and skip empty files when ingesting snapshot. That might be enough. We'd want to land this rather quickly. :)

[sakridge]

Just viewed the code. Really thanks for proposing PRs quickly once after I find the bugs!! The impl code looks nice for now.

Only add rooted append-vecs to the snapshot, for now skip any failures when we load the snapshot if an appendvec is in the index but not present as a file.

As you said, this might not be elegant, but it'll work. Maybe put empty files in place for skipped AppendVecs and skip empty files when ingesting snapshot. That might be enough. We'd want to land this rather quickly. :)

I agree, I think we should just land this and then the cleanup could be a follow-up PR.

[ryoqun]

@sakridge Thanks for merging and backporting! I'll build this locally and will run against tds to see snapshot errors disappear really. :)

[sakridge]

@sakridge Thanks for merging and backporting! I'll build this locally and will run against tds to see snapshot errors disappear really. :)

Thanks! I'm crossing my fingers for good luck :)

[ryoqun]

[ ] skipping the file on failure is not great, but when we serialize the storage entries, we don't know which slots are rooted. Find a better solution for that.

@sakridge Finally, this is now addressed at #10580. (FYI: @svenski123)