This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Make solana ping take optional lamports argument#7029
Merged
ryoqun merged 2 commits intosolana-labs:masterfrom Nov 19, 2019
Merged
Make solana ping take optional lamports argument#7029ryoqun merged 2 commits intosolana-labs:masterfrom
ryoqun merged 2 commits intosolana-labs:masterfrom
Conversation
mvines
previously approved these changes
Nov 19, 2019
Contributor
mvines
left a comment
mvines
left a comment
There was a problem hiding this comment.
cool, just some minor clap.rs nits
ryoqun
commented
Nov 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #7029 +/- ##
========================================
+ Coverage 73.7% 74.4% +0.6%
========================================
Files 225 223 -2
Lines 46259 45433 -826
========================================
- Hits 34125 33814 -311
+ Misses 12134 11619 -515 |
Contributor
Author
|
@mvines Once the CI passes (I'm pretty sure), I'll merge this! Thanks quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No strong usecase, but it's handy to able to set arbitrary number of lamports to send when
ping-ing.Particularly in my case, I needed this for 0 lamport while working on #6890 to create consistent flow of TXs avoiding some oneliners.