This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Update terminology for block height and genesis block#6782
Merged
jstarry merged 1 commit intosolana-labs:masterfrom Nov 7, 2019
Merged
Update terminology for block height and genesis block#6782jstarry merged 1 commit intosolana-labs:masterfrom
jstarry merged 1 commit intosolana-labs:masterfrom
Conversation
jstarry
force-pushed
the
one-indexed-block-height
branch
from
a5a1678 to
841d686
Compare
Codecov Report
@@ Coverage Diff @@
## master #6782 +/- ##
========================================
+ Coverage 73.2% 79.2% +5.9%
========================================
Files 219 219
Lines 45156 41766 -3390
========================================
+ Hits 33096 33097 +1
+ Misses 12060 8669 -3391 |
jstarry
changed the title
garious
approved these changes
Nov 7, 2019
This was referenced Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Terminology for block height and genesis block is a little off
Summary of Changes
Update terminology and add test for block height
Fixes #6779