Generate votes only if the proposed bank is not censoring the validator#6744
Generate votes only if the proposed bank is not censoring the validator#6744aeyakovenko wants to merge 4 commits intosolana-labs:masterfrom
Conversation
| "Vote dropped for bank {}, bank censorship failure!!!", | ||
| bank.slot() | ||
| ); | ||
| inc_new_counter_info!("replay_stage-votable_bank_censorship_failure", 1); |
There was a problem hiding this comment.
how do I plum the counter into the dashboard these days?
There was a problem hiding this comment.
hehe it's kind of a PIA. Usually you create the dashboard you want in Grafana, then copy the JSON model into testnet-monitor.json
Codecov Report
@@ Coverage Diff @@
## master #6744 +/- ##
========================================
- Coverage 67.6% 61.2% -6.5%
========================================
Files 219 219
Lines 48910 54142 +5232
========================================
+ Hits 33106 33138 +32
- Misses 15804 21004 +5200 |
mergify
Bot
dismissed
sagar-solana’s stale review
Pull request has been modified.
aeyakovenko
force-pushed
the
guard_against_censorship
branch
from
b34f256 to
02e5fba
Compare
aeyakovenko
force-pushed
the
guard_against_censorship
branch
from
02e5fba to
e765a4d
Compare
aeyakovenko
added
the
automerge
solana-grimes
removed
the
automerge
|
💔 Unable to automerge due to CI failure |
|
@aeyakovenko, the local cluster catchup tests won't pass unless the validators playing catch up set roots (issue we discussed yesterday). |
|
@carllin want to take this over? |
|
@mvines i don’t think we need this for 0.20 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
Bot
added
the
stale
|
@carllin - can you either rebase and help get this PR moving again, or just close it if obsolete. |
stale
Bot
removed
the
stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
Bot
added
the
stale
|
This stale pull request has been automatically closed. Thank you for your contributions. |
stale
Bot
removed
the
stale
|
@carllin, what's going on with this PR? |
|
On hold pending design of how to update root without voting so that validators catching up from a snapshot/reboot can update roots even while votes aren't landing |
|
Ok let's close this PR for now. Stale bot will again anyway, and there's a tracking issue so we won't forget about it |
6 participants
Problem
Validators may continue voting even though the network is dropping the votes.
Summary of Changes
If the delta between expected vote state and current vote state > THRESHOLD, consensus stops voting and lets some votes expire.
Fixes #6727