Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Add verifying snapshots book entry#5885

Merged
sakridge merged 1 commit intosolana-labs:masterfrom
sakridge:add-snapshot-verify-book
Sep 19, 2019
Merged

Add verifying snapshots book entry#5885
sakridge merged 1 commit intosolana-labs:masterfrom
sakridge:add-snapshot-verify-book

Conversation

@sakridge
Copy link
Copy Markdown
Contributor

Problem

Verifying snapshots xor schemed doesn't have a book entry.

Summary of Changes

Add snapshot xor book entry.

Fixes #

@sakridge sakridge force-pushed the add-snapshot-verify-book branch 2 times, most recently from d62f856 to 1e96e63 Compare September 17, 2019 19:45
@sakridge sakridge marked this pull request as ready for review September 17, 2019 19:45
Copy link
Copy Markdown
Contributor

@garious garious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this. This looks quite important to secure validator startup. Can you try to get this merged before the upcoming release?

Comment thread book/src/snapshot-verification.md
Comment thread book/src/snapshot-verification.md
Comment thread book/src/snapshot-verification.md
Comment thread book/src/snapshot-verification.md Outdated
Comment thread book/src/snapshot-verification.md Outdated
@sakridge sakridge force-pushed the add-snapshot-verify-book branch 3 times, most recently from c2be072 to 586513d Compare September 17, 2019 21:04
Comment thread book/src/snapshot-verification.md
@sakridge sakridge force-pushed the add-snapshot-verify-book branch from 586513d to 1050ca0 Compare September 18, 2019 01:58
@sakridge sakridge requested review from carllin and garious September 18, 2019 23:09
@sakridge sakridge force-pushed the add-snapshot-verify-book branch from 1050ca0 to 479745a Compare September 18, 2019 23:29
@sakridge sakridge added the automerge Merge this Pull Request automatically once CI passes label Sep 18, 2019
@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Sep 18, 2019
@solana-grimes
Copy link
Copy Markdown
Contributor

💔 Unable to automerge due to CI failure

@sakridge sakridge merged commit 48d7542 into solana-labs:master Sep 19, 2019
@sakridge sakridge deleted the add-snapshot-verify-book branch September 19, 2019 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants