Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

plumb some rent#5610

Merged
rob-solana merged 5 commits intosolana-labs:masterfrom
rob-solana:plumb-some-rent
Aug 23, 2019
Merged

plumb some rent#5610
rob-solana merged 5 commits intosolana-labs:masterfrom
rob-solana:plumb-some-rent

Conversation

@rob-solana
Copy link
Copy Markdown
Contributor

Problem

rent is unimplemented

Summary of Changes

step 0:

  • add rent_collector, which mods accounts at load() time
  • updated load to run rent_collector
  • set rent to zero for now
  • Instruction* types -> Transaction* types
  • use those types

Fixes #

@rob-solana rob-solana force-pushed the plumb-some-rent branch 2 times, most recently from 9966c85 to 0e76b82 Compare August 22, 2019 20:42
@rob-solana rob-solana requested a review from sakridge August 22, 2019 20:47
@rob-solana
Copy link
Copy Markdown
Contributor Author

rob-solana commented Aug 22, 2019

@sakridge once this is in place, we'll have to decide whether you hash() accounts before or after I deduct rent...

@rob-solana
Copy link
Copy Markdown
Contributor Author

rob-solana commented Aug 22, 2019

missing from this PR is keeping track of CO rent collection, which, because CO store() is skipped, we don't actually get the rent "collected". I think that code belongs in collect_accounts_to_store()

@rob-solana rob-solana force-pushed the plumb-some-rent branch 4 times, most recently from 5dc812f to 39648d4 Compare August 23, 2019 06:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 23, 2019

Codecov Report

Merging #5610 into master will increase coverage by 0.1%.
The diff coverage is 83.6%.

@@           Coverage Diff            @@
##           master   #5610     +/-   ##
========================================
+ Coverage    76.2%   76.3%   +0.1%     
========================================
  Files         217     218      +1     
  Lines       41560   41632     +72     
========================================
+ Hits        31685   31788    +103     
+ Misses       9875    9844     -31

@rob-solana rob-solana merged commit 0ffe7a9 into solana-labs:master Aug 23, 2019
@rob-solana rob-solana deleted the plumb-some-rent branch August 23, 2019 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant