Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Change JsonRpc exit to use wait->close#5566

Merged
carllin merged 2 commits intosolana-labs:masterfrom
carllin:FixJsonRpc
Aug 21, 2019
Merged

Change JsonRpc exit to use wait->close#5566
carllin merged 2 commits intosolana-labs:masterfrom
carllin:FixJsonRpc

Conversation

@carllin
Copy link
Copy Markdown
Contributor

@carllin carllin commented Aug 20, 2019

Problem

JsonRpcService exit does not currently guarantee threads have finished cleanup

Summary of Changes

  1. Change to use wait->close() in jsonrpc exit
  2. Change fullnode_exit() (invoked through RPC) to call the exit() method on a validator_exit() object which stores all the closures necessary to shutdown a validator

Fixes #

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 20, 2019

Codecov Report

Merging #5566 into master will increase coverage by 7%.
The diff coverage is 92.9%.

@@           Coverage Diff            @@
##           master   #5566     +/-   ##
========================================
+ Coverage    70.3%   77.3%     +7%     
========================================
  Files         217     217             
  Lines       45179   41068   -4111     
========================================
- Hits        31774   31773      -1     
+ Misses      13405    9295   -4110

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants