This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Change JsonRpc exit to use wait->close#5566
Merged
carllin merged 2 commits intosolana-labs:masterfrom Aug 21, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5566 +/- ##
========================================
+ Coverage 70.3% 77.3% +7%
========================================
Files 217 217
Lines 45179 41068 -4111
========================================
- Hits 31774 31773 -1
+ Misses 13405 9295 -4110 |
CriesofCarrots
approved these changes
Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JsonRpcService exit does not currently guarantee threads have finished cleanup
Summary of Changes
wait->close()in jsonrpc exitfullnode_exit()(invoked through RPC) to call theexit()method on avalidator_exit()object which stores all the closures necessary to shutdown a validatorFixes #