Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Default log level to to RUST_LOG=solana=info#5296

Merged
mvines merged 1 commit intosolana-labs:masterfrom
mvines:logyak
Jul 26, 2019
Merged

Default log level to to RUST_LOG=solana=info#5296
mvines merged 1 commit intosolana-labs:masterfrom
mvines:logyak

Conversation

@mvines
Copy link
Copy Markdown
Contributor

@mvines mvines commented Jul 26, 2019

solana-validator outputs nothing by default. The user needs to manually export RUST_LOG=solana=info, which is a pain.

We don't see this internally because multinode-demo/common.sh previously setup a nice RUST_LOG default for us.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@33de2ca). Click here to learn what that means.
The diff coverage is 50%.

@@           Coverage Diff            @@
##             master   #5296   +/-   ##
========================================
  Coverage          ?     78%           
========================================
  Files             ?     200           
  Lines             ?   37587           
  Branches          ?       0           
========================================
  Hits              ?   29319           
  Misses            ?    8268           
  Partials          ?       0

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@33de2ca). Click here to learn what that means.
The diff coverage is 50%.

@@           Coverage Diff            @@
##             master   #5296   +/-   ##
========================================
  Coverage          ?     78%           
========================================
  Files             ?     200           
  Lines             ?   37587           
  Branches          ?       0           
========================================
  Hits              ?   29319           
  Misses            ?    8268           
  Partials          ?       0

@mvines mvines merged commit c63a38a into solana-labs:master Jul 26, 2019
@mvines mvines deleted the logyak branch July 26, 2019 23:29
mvines added a commit that referenced this pull request Jul 27, 2019
mvines added a commit that referenced this pull request Jul 27, 2019
mvines added a commit to mvines/solana that referenced this pull request Jul 29, 2019
mvines added a commit that referenced this pull request Jul 29, 2019
…t need it (#5321)

* Revert "Revert "Default log level to to RUST_LOG=solana=info (#5296)" (#5302)"

This reverts commit 7796e87.

* Default to error logs, override with info only for those programs that need it
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant