Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Add test to exercise more args then registers#4661

Merged
jackcmay merged 2 commits intosolana-labs:masterfrom
jackcmay:too-many-args
Jun 12, 2019
Merged

Add test to exercise more args then registers#4661
jackcmay merged 2 commits intosolana-labs:masterfrom
jackcmay:too-many-args

Conversation

@jackcmay
Copy link
Copy Markdown
Contributor

Problem

BPF has 5 registers available to pass arguments into a function. LLVM backend currently warns and ignores any function arguments over 5.

#3099

Summary of Changes

Add a test to highlight this behavior that should be enabled when this issue is fixed.

Fixes #

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0dcdc37). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #4661   +/-   ##
========================================
  Coverage          ?   78.6%           
========================================
  Files             ?     183           
  Lines             ?   32569           
  Branches          ?       0           
========================================
  Hits              ?   25616           
  Misses            ?    6953           
  Partials          ?       0

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0dcdc37). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #4661   +/-   ##
========================================
  Coverage          ?   78.6%           
========================================
  Files             ?     183           
  Lines             ?   32569           
  Branches          ?       0           
========================================
  Hits              ?   25616           
  Misses            ?    6953           
  Partials          ?       0

@jackcmay jackcmay merged commit bc44516 into solana-labs:master Jun 12, 2019
@jackcmay jackcmay deleted the too-many-args branch June 12, 2019 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant