Continuous client #362
Merged
Continuous client #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Jun 15, 2018
src/bin/client-demo.rs
Outdated
| let time = Duration::new(time_sec, 0); | ||
| let now = Instant::now(); | ||
| while now.elapsed() < time { | ||
| println!( |
There was a problem hiding this comment.
Can you move everything within the while loop to a separate function?
src/bin/client-demo.rs
Outdated
| let signing_start = Instant::now(); | ||
| let transactions: Vec<_> = keypair_pairs | ||
| .par_iter() | ||
| .map(|chunk| Transaction::new(&chunk[0], chunk[1].pubkey(), 1, last_id)) |
There was a problem hiding this comment.
I'm curious, how are you calculating TPS if TX signing is inside the loop?
There was a problem hiding this comment.
the other thread is sampling it.
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
=========================================
- Coverage 90.78% 90.7% -0.09%
=========================================
Files 36 36
Lines 3482 3484 +2
=========================================
- Hits 3161 3160 -1
- Misses 321 324 +3
Continue to review full report at Codecov.
|
aeyakovenko
approved these changes
Jun 15, 2018
|
I don't believe the work has a specific 0.7 issue other than general TPS monitoring/improvement. |
Also retry for get_last_id/transaction_count if dropped.
sakridge
force-pushed
the
continuous_client
branch
from
88cb731
to
0b2ccdf
Compare
garious
approved these changes
Jun 15, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
willhickey
pushed a commit
to willhickey/solana
that referenced
this pull request
Mar 23, 2024
…na-labs#35330) (solana-labs#362) Bump platform tools version (solana-labs#35330) Co-authored-by: Dmitri Makarov <[email protected]>
willhickey
pushed a commit
that referenced
this pull request
Mar 23, 2024
…) (#362) Bump platform tools version (#35330) Co-authored-by: Dmitri Makarov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.