This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Revert partitioned rewards PDA commits#35088
Merged
CriesofCarrots merged 5 commits intoFeb 6, 2024
Merged
Conversation
added 5 commits
February 2, 2024 10:22
This reverts commit 22500c2.
…ccounts (solana-labs#34914)" This reverts commit b9947bd.
…abs#34624)" This reverts commit 4385ed1.
Contributor
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #35088 +/- ##
========================================
Coverage 81.6% 81.6%
========================================
Files 830 829 -1
Lines 224951 224820 -131
========================================
- Hits 183626 183583 -43
+ Misses 41325 41237 -88 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We decided to abandon solana-foundation/solana-improvement-documents#106
The RPC code will need to be reimplemented on top of the block metadata solution.
Summary of Changes
This has all the reverts in one PR. Approve this one to save some time (and do the magic to merge without squashing).