Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Revert "Add rpc support for partitioned rewards (#34773)"#35056

Closed
CriesofCarrots wants to merge 1 commit into
solana-labs:masterfrom
CriesofCarrots:revert-0
Closed

Revert "Add rpc support for partitioned rewards (#34773)"#35056
CriesofCarrots wants to merge 1 commit into
solana-labs:masterfrom
CriesofCarrots:revert-0

Conversation

@CriesofCarrots
Copy link
Copy Markdown
Contributor

@CriesofCarrots CriesofCarrots commented Feb 2, 2024

This reverts commit 22500c2.

Problem

We decided to abandon solana-foundation/solana-improvement-documents#106
This changeset will need to be recreated on top of the block metadata solution, but for now, reverting so we can pull out the PDA code

Summary of Changes

First revert. Approve this one if you want to go commit-by-commit.

@CriesofCarrots CriesofCarrots added the v1.18 PRs that should be backported to v1.18 label Feb 2, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 2, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2024

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (5dd9609) 81.6% compared to head (31aebca) 81.6%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #35056   +/-   ##
=======================================
  Coverage    81.6%    81.6%           
=======================================
  Files         830      830           
  Lines      224951   224862   -89     
=======================================
- Hits       183626   183592   -34     
+ Misses      41325    41270   -55     

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 5, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

v1.18 PRs that should be backported to v1.18

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant