This repository was archived by the owner on Jan 22, 2025. It is now read-only.
delay freeze of status_cache until squash#3503
Merged
rob-solana merged 1 commit intosolana-labs:v0.12from Mar 26, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.12 #3503 +/- ##
=======================================
- Coverage 81% 81% -0.1%
=======================================
Files 132 132
Lines 20826 20830 +4
=======================================
+ Hits 16877 16878 +1
- Misses 3949 3952 +3 |
joncinque
pushed a commit
to joncinque/agave
that referenced
this pull request
Nov 6, 2024
…a-labs#3194)" (solana-labs#3503) This reverts commit 69916f1.
Lichtso
pushed a commit
to Lichtso/solana
that referenced
this pull request
Nov 7, 2024
…a-labs#3194)" (solana-labs#3503) This reverts commit 69916f1.
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Nov 14, 2024
…olana-labs#3194)" (backport of solana-labs#3503) (solana-labs#3504) Revert "rolls back chained Merkle shreds for testnet downgrade (solana-labs#3194)" (solana-labs#3503) This reverts commit 69916f1. (cherry picked from commit db4f2d6) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
a race between the bank freezing and final transactions being committed exists in banking_stage that causes status updates to fail if the status_cache is frozen after a record, but while some transactions remain to be committed on other threads
Summary of Changes
delay status_cache freeze() until squash