This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add SyncClient trait and Bank implementation#3501
Closed
garious wants to merge 2 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3501 +/- ##
========================================
+ Coverage 79.3% 79.3% +<.1%
========================================
Files 151 152 +1
Lines 24179 24212 +33
========================================
+ Hits 19187 19216 +29
- Misses 4992 4996 +4 |
garious
force-pushed
the
add-sync-client
branch
2 times, most recently
from
2423b0e to
dc6c88e
Compare
garious
force-pushed
the
add-sync-client
branch
from
dc6c88e to
941b7a6
Compare
Contributor
Author
|
Wrong approach, back soon |
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Nov 14, 2024
…bs#3501) * Store epoch in MaxAge (solana-labs#3485) (cherry picked from commit 5a6f518) # Conflicts: # core/src/banking_stage/consumer.rs # core/src/banking_stage/scheduler_messages.rs # core/src/banking_stage/transaction_scheduler/transaction_state.rs # core/src/banking_stage/transaction_scheduler/transaction_state_container.rs * resolve conflicts --------- Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It's tricky to jump between solana_runtime and testnet. BankClient consumes keypairs, which is constraining and inconsistent with the other clients.
Summary of Changes
Introduce a SyncClient trait instead of wrapping Bank/Keypairs and implement that trait with Bank. The role of a SyncClient would be to update the transaction's blockhash, sign it, and resend as needed.
TODO:
Fixes #3058