This repository was archived by the owner on Jan 22, 2025. It is now read-only.
v1.16: add merkle root meta column to blockstore (backport of #33979)#34665
Merged
v1.16: add merkle root meta column to blockstore (backport of #33979)#34665
Conversation
* add merkle root meta column to blockstore * pr feedback: remove write/reads to column * pr feedback: u64 -> u32 + revert * pr feedback: fec_set_index u32, use Self::Index * pr feedback: key size 16 -> 12 (cherry picked from commit e457c02) # Conflicts: # ledger/src/blockstore.rs
behzadnouri
approved these changes
Jan 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v1.16 #34665 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 767 767
Lines 209271 209297 +26
=========================================
+ Hits 171297 171304 +7
- Misses 37974 37993 +19 |
Contributor
Author
|
Ok, I manually tested this PR. Namely,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Semi-automated backport of #33979; we had previously marked that branch for v1.16 BP in #34046, but I am unable to reopen that PR. This is the same state of those commits with a rebase for tip of v1.16
As for the motivation for this PR (discussion happened in Discord starting from here):