This repository was archived by the owner on Jan 22, 2025. It is now read-only.
v1.17: Add feature flag for LastIndex and Erasure duplicate proofs (backport of #34360)#34541
Merged
AshwinSekar merged 2 commits intov1.17from Dec 20, 2023
Merged
v1.17: Add feature flag for LastIndex and Erasure duplicate proofs (backport of #34360)#34541AshwinSekar merged 2 commits intov1.17from
AshwinSekar merged 2 commits intov1.17from
Conversation
* Add feature flag for LastIndex and Erasure duplicate proofs * pr feedback: use root bank instead of 2 params * pr feedback: & instead of &Arc * pr feedback: reuse fn, remove redundant clones * rebase: fix feature set conflict (cherry picked from commit def3bc4) # Conflicts: # sdk/src/feature_set.rs
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #34541 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 803 803
Lines 218209 218231 +22
=======================================
+ Hits 178523 178549 +26
+ Misses 39686 39682 -4 |
carllin
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #34360 done by Mergify.
Cherry-pick of def3bc4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com