Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements ReadableAccount for RefMut Account and AccountSharedData #34370

Closed

Conversation

brooksprumo
Copy link
Contributor

Problem

From this comment, https://github.com/solana-labs/solana/pull/34194/files#r1420665797, we'd like to use RefMut<AccountSharedData> as a ReadableAccount, but cannot directly. There are already implementations for Ref<_>, so this is just a gap.

Summary of Changes

Implements ReadableAccount for RefMut Account and AccountSharedData.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #34370 (268ac77) into master (5c00a33) will increase coverage by 0.0%.
Report is 22 commits behind head on master.
The diff coverage is 38.4%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34370   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         819      819           
  Lines      220422   220461   +39     
=======================================
+ Hits       180652   180685   +33     
- Misses      39770    39776    +6     

@brooksprumo
Copy link
Contributor Author

Closing. From #34194:

Since RefMut implements Deref<T>, callers can do a .deref() (or *) instead.

@brooksprumo brooksprumo deleted the readable-account/ref-mut branch December 18, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant