This repository was archived by the owner on Jan 22, 2025. It is now read-only.
v1.16: Add from field for message tracking (backport of #32725)#32746
Merged
gregcusack merged 1 commit intov1.16from Aug 9, 2023
Merged
v1.16: Add from field for message tracking (backport of #32725)#32746gregcusack merged 1 commit intov1.16from
gregcusack merged 1 commit intov1.16from
Conversation
Contributor
|
@Mergifyio rebase |
Contributor
Author
❌ Base branch update has failedDetailsGit reported the following error: err-code: 0DD2B |
Contributor
|
@Mergifyio refresh |
Contributor
Author
✅ Pull request refreshed |
behzadnouri
previously approved these changes
Aug 9, 2023
* we only want to report received message signatures on PUSH requests, not PULL requests * woops accidently had it has LocalMessage not PushMessage * switch from match to if let statement * convert if let to matches macro * add in from field in PushMessage for message tracking * update with cargo fmt * remove display for gossip route and add lifetime param to pubkey reference in gossiproute enum * forgot to run fmt
b1862bd to
649bd64
Compare
behzadnouri
approved these changes
Aug 9, 2023
Codecov Report
@@ Coverage Diff @@
## v1.16 #32746 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 762 762
Lines 207726 207727 +1
=======================================
+ Hits 170289 170310 +21
+ Misses 37437 37417 -20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #32725 done by Mergify.
Cherry-pick of 5c86f89 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com