This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Send messages to EntryNotifierService in Tpu, simpler#31962
Merged
mergify[bot] merged 5 commits intosolana-labs:masterfrom Jun 6, 2023
Merged
Send messages to EntryNotifierService in Tpu, simpler#31962mergify[bot] merged 5 commits intosolana-labs:masterfrom
mergify[bot] merged 5 commits intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31962 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 760 761 +1
Lines 207543 207461 -82
=========================================
- Hits 170048 169945 -103
- Misses 37495 37516 +21 |
carllin
reviewed
Jun 5, 2023
carllin
previously approved these changes
Jun 5, 2023
added 5 commits
June 5, 2023 16:55
CriesofCarrots
force-pushed
the
entry-notif-tpu-simple
branch
from
fc954a5 to
c0ee5d3
Compare
carllin
approved these changes
Jun 5, 2023
CriesofCarrots
added
v1.16
mergify Bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
* Add TpuEntryNotifier to send EntryNotifications from Tpu * Optionally run TpuEntryNotifier to send out EntrySummarys alongside BroadcastStage messages * Track entry index in TpuEntryNotifier * Allow for leader slots that switch forks * Exit if broadcast send fails (cherry picked from commit 8416099)
CriesofCarrots
pushed a commit
that referenced
this pull request
Jun 6, 2023
…t of #31962) (#31980) Send messages to EntryNotifierService in Tpu, simpler (#31962) * Add TpuEntryNotifier to send EntryNotifications from Tpu * Optionally run TpuEntryNotifier to send out EntrySummarys alongside BroadcastStage messages * Track entry index in TpuEntryNotifier * Allow for leader slots that switch forks * Exit if broadcast send fails (cherry picked from commit 8416099) Co-authored-by: Tyera <tyera@solana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An alternative to #31889
#31290 adds an entry notification service, which is currently only fed from the Tvu pipeline. But leaders should also support geyser entry notifications -- this is especially useful for testing plugins on solana-test-validator, since the TestValidator is the leader for every slot.
Summary of Changes
Adds a little service to sit between PohRecorder and BroadcastStage in the Tpu pipeline. If geyser entry notifications are supported, the entry summary information is copied from the message and sent to the entry notification service. All entries are passed through unchanged to the BroadcastStage receiver.
Differs from #31889 in that entry indexes are tracked in the TpuEntryNotifier instead of PohRecorder.
Closes #31889