This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Refactor - Merges BuiltinPrograms into LoadedPrograms#31654
Merged
Lichtso merged 2 commits intosolana-labs:masterfrom May 18, 2023
Merged
Refactor - Merges BuiltinPrograms into LoadedPrograms#31654Lichtso merged 2 commits intosolana-labs:masterfrom
BuiltinPrograms into LoadedPrograms#31654Lichtso merged 2 commits intosolana-labs:masterfrom
Conversation
116b769 to
7514743
Compare
7514743 to
cf57e0a
Compare
Codecov Report
@@ Coverage Diff @@
## master #31654 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 737 736 -1
Lines 205981 205913 -68
=========================================
- Hits 168738 168664 -74
- Misses 37243 37249 +6 |
pgarg66
reviewed
May 18, 2023
pgarg66
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Continuation of #31565.
Built-in programs should take the same paths through the program-runtime as user supplied programs do. This is an important step for their ongoing unification in program-runtime-v2.
Summary of Changes
genesis_builtins()andbuiltin_feature_transitions()with a static sliceBUILTINSBuiltinFeatureTransitionwithBuiltinPrototypewhich has an optionalPubkeyfor the activation feature, the valueNonesignals a built-in to be present at genesisbuiltins::create_builtin(), useloaded_programs::LoadedProgram::new_builtin()insteadBuiltinPrograms,Bank::builtin_programsandInvokeContext::builtin_programswith_mock_invoke_context_and_builtin_programs!()InvokeContext::programs_loaded_for_tx_batchinstead ofInvokeContext::builtin_programsLoadedProgram::account_sizetoname.len()for built-inseffective_slotanddeployment_slotto the slot in which their feature was activated