Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Fix hostname part of queries in dashboard#3161

Merged
solana-grimes merged 1 commit intosolana-labs:masterfrom
pgarg66:beacons_stability
Mar 6, 2019
Merged

Fix hostname part of queries in dashboard#3161
solana-grimes merged 1 commit intosolana-labs:masterfrom
pgarg66:beacons_stability

Conversation

@pgarg66
Copy link
Copy Markdown
Contributor

@pgarg66 pgarg66 commented Mar 6, 2019

Problem

The hostname part of some queries is looking up for the wrong keyword.

Summary of Changes

Change the keyword to match what's being stored in DB

Fixes #3156

@pgarg66 pgarg66 requested a review from mvines March 6, 2019 21:14
"orderByTime": "ASC",
"policy": "autogen",
"query": "SELECT mean(\"packets_received\") as \"packets_received\" FROM \"$testnet\".\"autogen\".\"net-stats\" WHERE host_id =~ /$hostid/ AND $timeFilter GROUP BY time(5s) fill(null)\n\n\n\n",
"query": "SELECT mean(\"packets_received\") as \"packets_received\" FROM \"$testnet\".\"autogen\".\"net-stats\" WHERE hostname =~ /$hostid/ AND $timeFilter GROUP BY time(5s) fill(null)\n\n\n\n",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about changing hostname to host_id in the net-stats and other scripts. That seems better approach, but it'll make older data format not parsable by the dashboard.

@pgarg66 pgarg66 added the automerge Merge this Pull Request automatically once CI passes label Mar 6, 2019
@solana-grimes solana-grimes merged commit 9d580e3 into solana-labs:master Mar 6, 2019
@pgarg66 pgarg66 deleted the beacons_stability branch March 6, 2019 21:41
buffalojoec pushed a commit to buffalojoec/solana that referenced this pull request Oct 15, 2024
Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
Szymongib pushed a commit to ChorusOne/solana that referenced this pull request Oct 28, 2024
…abs#3179)

* Scheduler: Improve TTL (solana-labs#3161)

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
(cherry picked from commit 7b0a573)

# Conflicts:
#	accounts-db/src/accounts.rs
#	core/src/banking_stage/consumer.rs
#	core/src/banking_stage/immutable_deserialized_packet.rs
#	core/src/banking_stage/latest_unprocessed_votes.rs
#	core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
#	runtime/src/bank/address_lookup_table.rs

* resolve conflicts

---------

Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants