This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Remove unnecessary cleanup_paths#3153
Merged
garious merged 1 commit intosolana-labs:masterfrom Mar 6, 2019
Merged
Conversation
drop handles it
sagar-solana
approved these changes
Mar 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #3153 +/- ##
=======================================
- Coverage 80.5% 78.6% -2%
=======================================
Files 129 134 +5
Lines 19533 19935 +402
=======================================
- Hits 15730 15674 -56
- Misses 3803 4261 +458 |
Szymongib
pushed a commit
to ChorusOne/solana
that referenced
this pull request
Oct 28, 2024
…tory (backport of solana-labs#3148) (solana-labs#3153) ledger-tool: Fix create-snapshot default value for output_directory (solana-labs#3148) The arguments to specify full and incremental snapshot archives paths used to be a global argument; these were moved to only be instantiated on commands that needed them in solana-labs#1773. But, when the arguments were moved from app-level to subcommand-level, the code that matches the arguments was not updated to look at subcommand-matches instead of app-matches. (cherry picked from commit 1d9947c) Co-authored-by: steviez <steven@anza.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Test doesn't need to explicitly cleanup
Summary of Changes
Remove cleanup_paths call.
Fixes #