This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Send messages to EntryNotifierService from blockstore_processor#31305
Merged
CriesofCarrots merged 3 commits intosolana-labs:masterfrom May 24, 2023
Merged
Send messages to EntryNotifierService from blockstore_processor#31305CriesofCarrots merged 3 commits intosolana-labs:masterfrom
CriesofCarrots merged 3 commits intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31305 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 737 737
Lines 205963 205970 +7
=========================================
+ Hits 168668 168673 +5
- Misses 37295 37297 +2 |
CriesofCarrots
force-pushed
the
entry-notif-tvu
branch
2 times, most recently
from
3cf9d00 to
736a7c0
Compare
CriesofCarrots
force-pushed
the
entry-notif-tvu
branch
from
736a7c0 to
7a8829b
Compare
carllin
reviewed
May 12, 2023
CriesofCarrots
force-pushed
the
entry-notif-tvu
branch
from
7a8829b to
a9bff0a
Compare
CriesofCarrots
force-pushed
the
entry-notif-tvu
branch
from
a9bff0a to
afce682
Compare
carllin
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#31290 adds an entry notification service -- only for nodes running with a geyser plugin that wants entry notifications -- but there isn't anywhere sending Entry messages to the service.
Summary of Changes
Hook up the Tvu path, sending Entry messages from
blockstore_processorNeeds rebase on #31290✅