This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Plumb Entry notification into plugin manager#30910
Merged
CriesofCarrots merged 1 commit intosolana-labs:masterfrom Mar 28, 2023
Merged
Plumb Entry notification into plugin manager#30910CriesofCarrots merged 1 commit intosolana-labs:masterfrom
CriesofCarrots merged 1 commit intosolana-labs:masterfrom
Conversation
CriesofCarrots
commented
Mar 27, 2023
| @@ -1,5 +1,6 @@ | |||
| #![allow(clippy::integer_arithmetic)] | |||
| mod cluster_tpu_info; | |||
| pub mod entry_notifier_interface; | |||
Contributor
Author
There was a problem hiding this comment.
I put this in solana-rpc because I thought we could piggyback off the TransactionStatusService (with a new TransactionStatusMessage variant) to call notify_entry()
Contributor
Author
There was a problem hiding this comment.
Might move this in a follow-up, depending on where the Entry notification service ends up.
| return; | ||
| } | ||
|
|
||
| let entry_info = Self::build_replica_entry_info(slot, index, entry); |
Contributor
Author
There was a problem hiding this comment.
While a lot of this file is copied from transaction_notifier.rs, I moved this line down, as there's no reason to build the entry info if plugins.is_empty(). This is probably inconsequential in terms of perf, but we could make this change in the other notifiers.
CriesofCarrots
force-pushed
the
geyser-manager-entry
branch
from
3a1999e to
2d2f930
Compare
Codecov Report
@@ Coverage Diff @@
## master #30910 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 726 727 +1
Lines 204914 204955 +41
=========================================
+ Hits 167065 167072 +7
- Misses 37849 37883 +34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#30872 added geyser interfaces for receiving/handling Entry notifications, but the validator plugin manager isn't yet able to actually send these notifications.
Summary of Changes
Add plumbing toward Entry notifications. This adds the geyser-plugin-manager pieces needed to construct and send the notifications, but still does not actually send them.