This repository was archived by the owner on Jan 22, 2025. It is now read-only.
banking bench tpu_disable_quic#30883
Merged
apfitzge merged 1 commit intosolana-labs:masterfrom Mar 24, 2023
Merged
Conversation
apfitzge
force-pushed
the
bugfix/banking-bench
branch
from
2123a4f to
304007b
Compare
apfitzge
commented
Mar 24, 2023
| ClusterInfo::new(node.info, keypair, SocketAddrSpace::Unspecified) | ||
| }; | ||
| let cluster_info = Arc::new(cluster_info); | ||
| let tpu_use_quic = matches.is_present("tpu_use_quic"); |
Contributor
Author
There was a problem hiding this comment.
this always fails because "tpu_use_quic" is not a registered argument with matches.
Codecov Report
@@ Coverage Diff @@
## master #30883 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 726 726
Lines 204800 204800
=======================================
+ Hits 167015 167034 +19
+ Misses 37785 37766 -19 |
willhickey
approved these changes
Mar 24, 2023
Contributor
willhickey
left a comment
willhickey
left a comment
There was a problem hiding this comment.
Thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#27194 changed the cli argument name to
tpu_disable_quicbut didn't adjust the matches use in banking-bench.Summary of Changes
Change the usage from
tpu_use_quictotpu_disable_quicFixes #