This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fnbool_to_FnOptionT#3041
Merged
solana-grimes merged 1 commit intosolana-labs:masterfrom Mar 1, 2019
Merged
Conversation
garious
approved these changes
Mar 1, 2019
Contributor
garious
left a comment
garious
left a comment
There was a problem hiding this comment.
Interesting. I was thinking there was a double-call to get_balance that'd go away as a result of having this.
Contributor
|
I see it. Need this same change to be made to |
carllin
approved these changes
Mar 1, 2019
rob-solana
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #3041 +/- ##
========================================
+ Coverage 77.2% 77.3% +<.1%
========================================
Files 132 132
Lines 20182 20185 +3
========================================
+ Hits 15599 15606 +7
+ Misses 4583 4579 -4 |
steviez
pushed a commit
to steviez/solana
that referenced
this pull request
Nov 4, 2024
Lichtso
pushed a commit
to Lichtso/solana
that referenced
this pull request
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
epoch_vote_states() is clumsy, operates on a bool closure
Summary of Changes
move to Option, more flexible
Fixes #