This repository was archived by the owner on Jan 22, 2025. It is now read-only.
v1.15: Add address lookup tables to minimized snapshot (backport of #30158)#30237
Closed
mergify[bot] wants to merge 1 commit intov1.15from
Closed
v1.15: Add address lookup tables to minimized snapshot (backport of #30158)#30237mergify[bot] wants to merge 1 commit intov1.15from
mergify[bot] wants to merge 1 commit intov1.15from
Conversation
* Add address lookup tables to minimized snapshot * Add comment for future posterity * Add reference to the issue * Adjust comment a bit Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com> --------- Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com> (cherry picked from commit 3e6162e)
apfitzge
reviewed
Feb 10, 2023
Contributor
apfitzge
left a comment
apfitzge
left a comment
There was a problem hiding this comment.
Changes are same as in v16, and still look good to me. Relatively small and patches a known bug in ledger-tool.
I'm slightly hesitant to backport since its' not a "critical" fix, as I'm not sure many use this feature. Will think some more on it, and maybe discuss on discord tomorrow
Contributor
hehe, glad that this isn't rubber stamp. ;) this new bp check flow seems to create some cool down period. Okay, just happened to look recent discussions at discord's #releng w.r.t. other ledger-tool's pr. having read that, I'm closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #30158 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com