This repository was archived by the owner on Jan 22, 2025. It is now read-only.
removes LegacyContactInfo::is_valid_tvu_address#29570
Merged
behzadnouri merged 1 commit intosolana-labs:masterfrom Jan 8, 2023
Merged
removes LegacyContactInfo::is_valid_tvu_address#29570behzadnouri merged 1 commit intosolana-labs:masterfrom
behzadnouri merged 1 commit intosolana-labs:masterfrom
Conversation
Since solana-labs#20480 turbine includes all epoch staked nodes in tree construction and no longer relies on obtaining their contact-info from gossip; and so distinguishing between is_valid_address and is_valid_tvu_address is no longer necessary and the latter can be removed.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Jan 10, 2023
Since solana-labs#20480 turbine includes all epoch staked nodes in tree construction and no longer relies on obtaining their contact-info from gossip; and so distinguishing between is_valid_address and is_valid_tvu_address is no longer necessary and the latter can be removed.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Jan 10, 2023
Since solana-labs#20480 turbine includes all epoch staked nodes in tree construction and no longer relies on obtaining their contact-info from gossip; and so distinguishing between is_valid_address and is_valid_tvu_address is no longer necessary and the latter can be removed.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Jan 10, 2023
Since solana-labs#20480 turbine includes all epoch staked nodes in tree construction and no longer relies on obtaining their contact-info from gossip; and so distinguishing between is_valid_address and is_valid_tvu_address is no longer necessary and the latter can be removed.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Jan 10, 2023
Since solana-labs#20480 turbine includes all epoch staked nodes in tree construction and no longer relies on obtaining their contact-info from gossip; and so distinguishing between is_valid_address and is_valid_tvu_address is no longer necessary and the latter can be removed.
mergify Bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
Since #20480 turbine includes all epoch staked nodes in tree construction and no longer relies on obtaining their contact-info from gossip; and so distinguishing between is_valid_address and is_valid_tvu_address is no longer necessary and the latter can be removed. (cherry picked from commit 677b6d6)
behzadnouri
added a commit
that referenced
this pull request
Jan 25, 2023
…9904) removes LegacyContactInfo::is_valid_tvu_address (#29570) Since #20480 turbine includes all epoch staked nodes in tree construction and no longer relies on obtaining their contact-info from gossip; and so distinguishing between is_valid_address and is_valid_tvu_address is no longer necessary and the latter can be removed. (cherry picked from commit 677b6d6) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #20480, turbine includes all epoch staked nodes in tree construction and no longer relies on obtaining their contact-info from gossip; and so distinguishing between
is_valid_addressandis_valid_tvu_addressis no longer necessary and the latter can be removed.Summary of Changes
removed
LegacyContactInfo::is_valid_tvu_address.