This repository was archived by the owner on Jan 22, 2025. It is now read-only.
allow ancient append vec threshold to be set on cli#28707
Merged
jeffwashington merged 2 commits intosolana-labs:masterfrom Nov 11, 2022
Merged
allow ancient append vec threshold to be set on cli#28707jeffwashington merged 2 commits intosolana-labs:masterfrom
jeffwashington merged 2 commits intosolana-labs:masterfrom
Conversation
jeffwashington
force-pushed
the
nov4
branch
5 times, most recently
from
5b71a6e to
0b946c6
Compare
jeffwashington
changed the title
jeffwashington
force-pushed
the
nov4
branch
6 times, most recently
from
20521b2 to
96b1621
Compare
apfitzge
reviewed
Nov 4, 2022
Contributor
apfitzge
left a comment
apfitzge
left a comment
There was a problem hiding this comment.
Like the change overall. Concern on the CLI default (I probably don't understand clap) and some comments
jeffwashington
force-pushed
the
nov4
branch
3 times, most recently
from
0ee8f9e to
cd966bf
Compare
apfitzge
previously approved these changes
Nov 10, 2022
Contributor
apfitzge
left a comment
apfitzge
left a comment
There was a problem hiding this comment.
minor typo, other than that it looks good.
mergify
Bot
dismissed
apfitzge’s stale review
Pull request has been modified.
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Nov 16, 2022
* allow ancient append vec threshold to be set on cli * pr responses
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
* allow ancient append vec threshold to be set on cli * pr responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For testing ancient append vecs, allow caller to specify an offset for how many additional slots within the last epoch to include into ancient append vecs. This causes the ancient append vec code to run more normally while we're still collecting rent.
Ancient append vecs are behind this cli arg, so this will not affect any real validators or tests.
Summary of Changes
Fixes #