Refactor, move solana-validator CLI related configs to its own module

[eloylp]

Problem

The main function of the validator is getting big. I found it a bit difficult to track the code.

Summary of Changes

There is no behavioural change on this PR. Its just a refactor:

• Move the CLI initialisation code and validations to their own module, cli.rs, leaving the main function a bit more lightweight.
• Group all the default arguments in a dedicated struct. So easier to find and alter them.

Checks that i did

The most sensible change here are the defaults grouping. As the CLI defaults are shown in the output when invoking it with --help, i thought the following commands to be useful for a minimal check, to ensure no behavioural change:

cd solana/validator
## Save CLI output with defaults in master
$ git checkout master
$ cargo run -- --help > /tmp/master-cli-output.txt
## Save CLI output with defaults in the refactor branch
$ git checkout refactor-validator-main
$ cargo run -- --help > /tmp/refactor-cli-output.txt
## Compare md5 sums 
$ md5sum /tmp/master-cli-output.txt /tmp/refactor-cli-output.txt
12768cba6bb80d63e77b52fe162657d5  /tmp/master-cli-output.txt
12768cba6bb80d63e77b52fe162657d5  /tmp/refactor-cli-output.txt

And similar for the test validator part:

$ cd solana/validator

$ git checkout master
$ ./solana-test-validator --help > /tmp/master-test-cli-output.txt

$ git checkout refactor-validator-main
$ ./solana-test-validator --help > /tmp/refactor-test-cli-output.txt

$ md5sum /tmp/master-test-cli-output.txt /tmp/refactor-test-cli-output.txt 
c75c7b2a81c23961f68929838d07d5b9  /tmp/master-test-cli-output.txt
c75c7b2a81c23961f68929838d07d5b9  /tmp/refactor-test-cli-output.txt

Edit: updated with latest changes (conflict solving).

Edit2: updated with latest changes (conflict solving). Added test validator check.

[eloylp]

Solved conflicts. Looks like 2 arguments related to blockstore were deprecated at #28409 . Ready for review !

[eloylp]

Hi @mvines , apologies for the direct ping, just trying to follow contributing guides . Could you help me on reviewing this ? Thank you in advance !

[eloylp]

Ouups, just realised it got conflicts again. Will move it to draft again. Early feedback still appreciated.

[eloylp]

The branch is now updated with latest changes. The last conflict was due to this new addition . I think this is ready for review again.

[mvines]

Thanks for doing this. Looks fine to me overall, just one nit.

Do you think validator/src/bin/solana-test-validator.rs deserves the same treatment for its cli config?

[mvines]

Oops can you please restore this line

[eloylp]

Fixed at ae6f93f

[mvines]

Looks like CI wants you to run cargo fmt :)

[eloylp]

Hello @mvines. Here is a list of updates:

• Do you think validator/src/bin/solana-test-validator.rs deserves the same treatment for its cli config?

Yes. I was worried about the size of the PR. Planned to do it a second PR. But here is it f31988c . Let me know what do you think. I did the same md5 checks as in the first refactor (see updated PR description).

• Updated with latest changes from master. A conflict was fixed, due to this PR . I did again the md5 checks (see PR description).

• Configured cargo fmt "on save" on my new setup. It should not fail again :)

Probably a squash is a good idea if merged. I think this is ready for review again !

[eloylp]

Ah ! gotcha. CI failed again. Thats probably because:

$ cargo fmt --all
Warning: can't set `imports_granularity = One`, unstable features are only available in nightly channel.
...

This one did the trick:

cargo +nightly fmt --all

Fixed at 5b05edc . I hope. Sorry inconveniences.

[mvines]

Thanks for the PR!

[eloylp]

Thanks for the PR!

Thanks for review 🙂