This repository was archived by the owner on Jan 22, 2025. It is now read-only.
removes feature gate code preserving rent_epoch for rent exempt accounts#28507
Merged
behzadnouri merged 2 commits intosolana-labs:masterfrom Nov 1, 2022
Merged
Conversation
behzadnouri
force-pushed
the
rm-preserve-rent-epoch-feature
branch
4 times, most recently
from
805af9c to
d654943
Compare
Contributor
|
I pushed updates to the bank test: |
behzadnouri
force-pushed
the
rm-preserve-rent-epoch-feature
branch
from
557a3b6 to
b6cf004
Compare
| if !preserve_rent_epoch_for_rent_exempt_accounts | ||
| && account.rent_epoch() == INITIAL_RENT_EPOCH | ||
| { | ||
| let rent = rent_collector |
Contributor
There was a problem hiding this comment.
@behzadnouri
This PR looks like it is correctly removing the feature.
I am not entirely sure what this code here is doing. Is this code gone because we aren't allowed to create rent paying accounts anymore so the only side effect was updating rent_epoch?
Contributor
There was a problem hiding this comment.
for posterity, from behzad:
that branch was added separately in:
#26851
the PR has some context
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
…nts (solana-labs#28507) * removes feature gate code preserving rent_epoch for rent exempt accounts * update test expected hashes Co-authored-by: jeff washington <jeff.washington@solana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
feature is activated on all clusters
Summary of Changes
removed feature gate code
Fixes #26509