This repository was archived by the owner on Jan 22, 2025. It is now read-only.
enforces hash domain for ping-pong protocol#28433
Merged
behzadnouri merged 1 commit intosolana-labs:masterfrom Oct 18, 2022
Merged
enforces hash domain for ping-pong protocol#28433behzadnouri merged 1 commit intosolana-labs:masterfrom
behzadnouri merged 1 commit intosolana-labs:masterfrom
Conversation
solana-labs#27193 added hash domain to ping-pong protocol. For backward compatibility responses both with and without domain were generated and accepted. Now that all clusters are upgraded, this commit enforces the hash domain by removing the response without the domain.
behzadnouri
force-pushed
the
rm-extra-ping
branch
from
8863aa0 to
7174e61
Compare
mergify Bot
added a commit
that referenced
this pull request
Oct 18, 2022
enforces hash domain for ping-pong protocol (#28433) #27193 added hash domain to ping-pong protocol. For backward compatibility responses both with and without domain were generated and accepted. Now that all clusters are upgraded, this commit enforces the hash domain by removing the response without the domain. (cherry picked from commit e283461) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
mergify Bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
#27193 added hash domain to ping-pong protocol. For backward compatibility responses both with and without domain were generated and accepted. Now that all clusters are upgraded, this commit enforces the hash domain by removing the response without the domain. (cherry picked from commit e283461) # Conflicts: # gossip/src/cluster_info.rs
mergify Bot
added a commit
that referenced
this pull request
Nov 28, 2022
* enforces hash domain for ping-pong protocol (#28433) #27193 added hash domain to ping-pong protocol. For backward compatibility responses both with and without domain were generated and accepted. Now that all clusters are upgraded, this commit enforces the hash domain by removing the response without the domain. (cherry picked from commit e283461) # Conflicts: # gossip/src/cluster_info.rs * removes mergify merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
solana-labs#27193 added hash domain to ping-pong protocol. For backward compatibility responses both with and without domain were generated and accepted. Now that all clusters are upgraded, this commit enforces the hash domain by removing the response without the domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#27193 added hash domain to ping-pong protocol.
For backward compatibility responses both with and without domain were generated and accepted.
Now that all clusters are upgraded, this commit enforces the hash domain by removing the response without the domain.
Summary of Changes
enforce hash domain for ping-pong protocol