This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Pull RpcSubscriptions out of the Bank#2806
Merged
garious merged 4 commits intosolana-labs:masterfrom Feb 19, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2806 +/- ##
========================================
- Coverage 77.4% 77.4% -0.1%
========================================
Files 125 125
Lines 19048 19033 -15
========================================
- Hits 14754 14736 -18
- Misses 4294 4297 +3 |
garious
force-pushed
the
boot-subscriptions
branch
from
134ba93 to
6f04d61
Compare
garious
force-pushed
the
boot-subscriptions
branch
2 times, most recently
from
14ea25b to
c235e83
Compare
Pass in RpcSubscriptions instead, which let's you choose a bank fork when it's time to send notifications.
garious
force-pushed
the
boot-subscriptions
branch
from
c235e83 to
436adc7
Compare
Contributor
Author
|
@mvines, for apps like tic-tac-toe, this might not work quite as you'd expect until we start checkpointing on every block. Even so, if this change is remotely tolerable (get it?), then I'd like to merge it. I have bigger fish to fry. Maybe pull it down locally for a few sanity checks before this goes in? |
Contributor
Author
|
@CriesofCarrots, feel free to review post-merge |
2 tasks
jeffwashington
added a commit
to jeffwashington/solana
that referenced
this pull request
Sep 4, 2024
* unref accounts in shink and pack when we're committed * remove bad comments * rewrite shrink_ancient_fail_ref test * fix comments * fix a test * fix another test * fmt * del invalid comments * reviews: move log to new PR. * Revert "reviews: move log to new PR." This reverts commit f8aefe0. * fix comments * revert log content * pr: rename * pr: more rename --------- Co-authored-by: HaoranYi <haoran.yi@anza.xyz>
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
Sep 4, 2024
* unref accounts in shink and pack when we're committed * remove bad comments * rewrite shrink_ancient_fail_ref test * fix comments * fix a test * fix another test * fmt * del invalid comments * reviews: move log to new PR. * Revert "reviews: move log to new PR." This reverts commit f8aefe0. * fix comments * revert log content * pr: rename * pr: more rename --------- Co-authored-by: HaoranYi <haoran.yi@anza.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Notifications are not fork-aware. We notify as soon as either a TPU or TVU commits transactions. Instead, we should notify on block boundaries and any time we switch forks (right after a vote).
Summary of Changes
Remove notifications from the bank and rewire the PubSub tests to be more unit-testy.
TODO: