This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Restore aliasing rules in BPF loader.#27752
Merged
Lichtso merged 1 commit intosolana-labs:masterfrom Sep 13, 2022
Merged
Conversation
Contributor
|
The change as is runs the risk of breaking testnet consensus as nodes upgrade to the new v1.11/v1.14 version that contains this fix. I think this risk is ok and an opportunity to practice a testnet restart. When this happens, we'll just need to get all testnet nodes not running this patch to upgrade as a part of their restart |
mergify Bot
pushed a commit
that referenced
this pull request
Sep 13, 2022
(cherry picked from commit c9eac2e)
Lichtso
added a commit
that referenced
this pull request
Sep 16, 2022
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Sep 26, 2022
…olana-labs#27760) Restore aliasing rules in BPF loader. (solana-labs#27752) (cherry picked from commit c9eac2e) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The refactoring in #24381 overlooked statements in which the
keyed_account.try_account_ref_mut()expression stayed borrowed while another account is being accessed. This caused some aliasing restrictions to be effectively lifted and broke consensus.Summary of Changes
Restores the following aliasing restrictions of as they were in 1.10.
UpgradableLoaderInstruction::DeployWithMaxDataLen: buffer != payerUpgradableLoaderInstruction::Upgrade: buffer != spill, programdata != spillUpgradableLoaderInstruction::Close: close != recipientFixes #27740