This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Use regex in get_snapshot_file_kind#27728
Merged
apfitzge merged 1 commit intosolana-labs:masterfrom Sep 22, 2022
Merged
Conversation
apfitzge
commented
Sep 12, 2022
| } | ||
|
|
||
| /// Determines `SnapshotFileKind` for `filename` if any | ||
| fn get_snapshot_file_kind(filename: &str) -> Option<SnapshotFileKind> { |
Contributor
Author
There was a problem hiding this comment.
Is something like this what you had in mind @brooksprumo?
Contributor
There was a problem hiding this comment.
Yes! Looks good to me. Thanks for doing this.
apfitzge
force-pushed
the
refactor/get_snapshot_file_kind_regex
branch
from
cfdf9a5 to
26ff2d4
Compare
brooksprumo
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow up for #27484. Refactor
get_snapshot_file_kindto use regex.Summary of Changes
Refactor
get_snapshot_file_kindto use regex.Fixes #