This repository was archived by the owner on Jan 22, 2025. It is now read-only.
feat: add TransactionMessage class#27526
Merged
mergify[bot] merged 1 commit intosolana-labs:masterfrom Sep 7, 2022
Merged
Conversation
65 tasks
72c6339 to
e8aa3d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #27526 +/- ##
=========================================
+ Coverage 77.6% 77.7% +0.1%
=========================================
Files 54 55 +1
Lines 2770 2850 +80
Branches 379 392 +13
=========================================
+ Hits 2150 2216 +66
- Misses 484 495 +11
- Partials 136 139 +3 |
e8aa3d4 to
6c74068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Lack of a common interface for creating and displaying transactions which supports both legacy and versioned transactions
Summary of Changes
TransactionMessageclass which can be used to construct or decompile legacy and v0 transactions.Message.compilemethod to the legacy message class to mirror the equivalentMessageV0.compilemethod added in feat: implement message v0 compilation #27524getAccountKeysmethod to bothMessageandMessageV0classes for use in transaction decompilation and to allow devs to conveniently resolve account indexes with a common interface for legacy and versioned transactionsresolveAddressTableLookupsmethod toMessageV0which is used to decompile v0 transactionsFixes #