This repository was archived by the owner on Jan 22, 2025. It is now read-only.
fix: add compute units to jsonrpc parser#27466
Merged
steveluscher merged 1 commit intosolana-labs:masterfrom Sep 1, 2022
Merged
fix: add compute units to jsonrpc parser#27466steveluscher merged 1 commit intosolana-labs:masterfrom
steveluscher merged 1 commit intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27466 +/- ##
=======================================
Coverage 76.7% 76.7%
=======================================
Files 52 52
Lines 2651 2651
Branches 364 364
=======================================
Hits 2035 2035
Misses 483 483
Partials 133 133 |
steveluscher
reviewed
Sep 1, 2022
Comment on lines
+870
to
+871
| /** The addresses of the accounts loaded for the transaction */ | ||
| loadedAddresses?: LoadedAddresses | null; |
Contributor
Contributor
There was a problem hiding this comment.
Yup it was missed but recently added in #27068, this addition just broke master unfortunately. In the future let's keep unrelated changes out of PR's
Contributor
There was a problem hiding this comment.
Haha. Scroll down, @steveluscher. Sorry about that.
Contributor
There was a problem hiding this comment.
Oh no worries! Merge conflicts happen, and it was originally my fault for missing that field :)
jstarry
added a commit
that referenced
this pull request
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The auto-complete of my editor did not show the computeUnitsConsumed field.
Tested with this example script: