This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Update rollup script to exclude new secp256k1 and hmac/sha256 dependencies#27428
Merged
steveluscher merged 2 commits intosolana-labs:masterfrom Aug 26, 2022
steveluscher:always-forget-to-update-rollup-script
Merged
Update rollup script to exclude new secp256k1 and hmac/sha256 dependencies#27428steveluscher merged 2 commits intosolana-labs:masterfrom steveluscher:always-forget-to-update-rollup-script
steveluscher merged 2 commits intosolana-labs:masterfrom
steveluscher:always-forget-to-update-rollup-script
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27428 +/- ##
=========================================
- Coverage 76.9% 76.8% -0.1%
=========================================
Files 48 51 +3
Lines 2505 2657 +152
Branches 355 363 +8
=========================================
+ Hits 1927 2043 +116
- Misses 448 482 +34
- Partials 130 132 +2 |
This was referenced Oct 13, 2024
This was referenced Oct 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I always forget to do this, and there's no static analysis to stop this mistake from being made.
Summary of Changes
Test plan
Inspect ESM bundles in
/lib/. Observe that@noble/hashesand@noble/secp256k1are no longer inlined.