Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Call AccountsDb::clean_accounts() directly, inside Bank::verify_snapshot_bank() #27258

Merged
brooksprumo merged 1 commit into from
Aug 22, 2022
Merged

Call AccountsDb::clean_accounts() directly, inside Bank::verify_snapshot_bank() #27258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion runtime/src/bank.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7159,7 +7159,10 @@ impl Bank {
let mut clean_time = Measure::start("clean");
if !accounts_db_skip_shrink && self.slot() > 0 {
info!("cleaning..");
self._clean_accounts(true, true, Some(last_full_snapshot_slot));
self.rc
.accounts
.accounts_db
.clean_accounts(None, true, Some(last_full_snapshot_slot));
Comment on lines +7162 to +7165
Copy link
Copy Markdown
Contributor Author

@brooksprumo brooksprumo Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that previously we'd call clean_accounts() with max_clean_root = Some(self.slot() - 1), and now we call clean_accounts() with max_root = None.

I believe this is safe for the reasons I put in the PR description. Please let me know if I've missed something!

}
clean_time.stop();

Expand Down