This repository was archived by the owner on Jan 22, 2025. It is now read-only.
adds hash domain to ping-pong protocol (backport #27193)#27243
Merged
behzadnouri merged 2 commits intov1.10from Aug 19, 2022
Merged
adds hash domain to ping-pong protocol (backport #27193)#27243behzadnouri merged 2 commits intov1.10from
behzadnouri merged 2 commits intov1.10from
Conversation
Contributor
Author
|
automerge label removed due to a CI failure |
Contributor
Author
|
automerge label removed due to a CI failure |
Contributor
Author
|
automerge label removed due to a CI failure |
Contributor
Author
|
automerge label removed due to a CI failure |
Contributor
|
@Mergifyio rebase |
In order to maintain backward compatibility, for now the responding node will hash the token both with and without domain so that the other node will accept the response regardless of its upgrade status. Once the cluster has upgraded to the new code, we will remove the legacy domain = false case. (cherry picked from commit 6928b2a) # Conflicts: # gossip/src/cluster_info.rs
Contributor
Author
✅ Branch has been successfully rebased |
a9a1432 to
881b7e3
Compare
Contributor
Author
|
automerge label removed due to a CI failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #27193 done by Mergify.
Cherry-pick of 6928b2a has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com