This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Increase transaction account lock limit from 64 to 128#27242
Merged
Conversation
jstarry
added
the
feature-gate
jstarry
force-pushed
the
feat/bump-lock-limit
branch
2 times, most recently
from
418d1d7 to
b7f28de
Compare
Lichtso
previously approved these changes
Aug 22, 2022
Contributor
Lichtso
left a comment
Lichtso
left a comment
There was a problem hiding this comment.
I think the change set is technically correct, but I am still having doubts if this is the right direction to go for.
Contributor
|
More write locks do reduce the maximal parallel execution. So, I would recommend adding some cost to locking additional accounts and doing so in the same feature gate. |
Contributor
|
Updated label to v1.14 which is effectively the new v1.11 See discussion on Discord in #releng and #proj-quic-tpu for more context. |
jstarry
changed the title
jstarry
force-pushed
the
feat/bump-lock-limit
branch
from
b7f28de to
765f288
Compare
mergify
Bot
dismissed
Lichtso’s stale review
Pull request has been modified.
jstarry
force-pushed
the
feat/bump-lock-limit
branch
from
765f288 to
776d37b
Compare
Contributor
Author
|
@Lichtso I'm going to merge now to get this enabled on devnet but will refrain from updating on mainnet-beta until getting consensus on what the cost updates should be |
mergify Bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
* Increase transaction account lock limit from 64 to 256 * fix bpf test * Reduce lock limit from 256 to 128 (cherry picked from commit b970024) # Conflicts: # programs/bpf/tests/programs.rs # programs/bpf_loader/src/syscalls/cpi.rs # runtime/src/bank.rs # sdk/bpf/c/inc/sol/cpi.h # sdk/bpf/c/inc/sol/inc/cpi.inc # sdk/program/src/syscalls/mod.rs # sdk/src/feature_set.rs
mergify Bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
* Increase transaction account lock limit from 64 to 256 * fix bpf test * Reduce lock limit from 256 to 128 (cherry picked from commit b970024) # Conflicts: # runtime/src/bank.rs # sdk/src/feature_set.rs
jstarry
added a commit
to jstarry/solana
that referenced
this pull request
Sep 16, 2022
jstarry
added a commit
that referenced
this pull request
Sep 16, 2022
jstarry
added a commit
that referenced
this pull request
Sep 16, 2022
jstarry
added a commit
that referenced
this pull request
Sep 16, 2022
jstarry
added a commit
that referenced
this pull request
Sep 16, 2022
|
Is this going to happen or not? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The transaction account lock limit is currently set to 64 which is too limiting for use-cases like the Neon EVM
Summary of Changes
Added a feature gate that bumps the account lock limit and CPI account info limit both to 128.
Fixes: #27756
Feature Gate Issue: #27241