Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Fix local cluster tests for QUIC usage#27071

Merged
CriesofCarrots merged 1 commit intosolana-labs:masterfrom
pgarg66:fix-local-cluster-tests
Aug 11, 2022
Merged

Fix local cluster tests for QUIC usage#27071
CriesofCarrots merged 1 commit intosolana-labs:masterfrom
pgarg66:fix-local-cluster-tests

Conversation

@pgarg66
Copy link
Copy Markdown
Contributor

@pgarg66 pgarg66 commented Aug 10, 2022

Problem

The local cluster tests are failing when QUIC is enabled.

Summary of Changes

The IP address used for connection (0.0.0.0) didn't match what was used for creating the authentication certificate (127.0.0.1). Changing the server address to 127.0.0.1 fixes the issue.

Fixes #

@pgarg66 pgarg66 requested a review from CriesofCarrots August 11, 2022 00:07
@pgarg66 pgarg66 marked this pull request as ready for review August 11, 2022 00:12
@pgarg66 pgarg66 added the v1.11 label Aug 11, 2022
Copy link
Copy Markdown
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make so much sense; thanks for tracking it down!

@CriesofCarrots CriesofCarrots merged commit ce23003 into solana-labs:master Aug 11, 2022
mergify Bot pushed a commit that referenced this pull request Aug 11, 2022
mergify Bot added a commit that referenced this pull request Aug 11, 2022
Fix local cluster tests for QUIC usage (#27071)

(cherry picked from commit ce23003)

Co-authored-by: Pankaj Garg <pankaj@solana.com>
@pgarg66 pgarg66 deleted the fix-local-cluster-tests branch August 11, 2022 14:15
xiangzhu70 pushed a commit to xiangzhu70/solana that referenced this pull request Aug 17, 2022
lijunwangs pushed a commit to lijunwangs/solana that referenced this pull request Sep 12, 2022
…olana-labs#27077)

Fix local cluster tests for QUIC usage (solana-labs#27071)

(cherry picked from commit ce23003)

Co-authored-by: Pankaj Garg <pankaj@solana.com>
lijunwangs pushed a commit to lijunwangs/solana that referenced this pull request Sep 13, 2022
…olana-labs#27077)

Fix local cluster tests for QUIC usage (solana-labs#27071)

(cherry picked from commit ce23003)

Co-authored-by: Pankaj Garg <pankaj@solana.com>
lijunwangs pushed a commit to lijunwangs/solana that referenced this pull request Sep 13, 2022
…olana-labs#27077)

Fix local cluster tests for QUIC usage (solana-labs#27071)

(cherry picked from commit ce23003)

Co-authored-by: Pankaj Garg <pankaj@solana.com>
lijunwangs pushed a commit that referenced this pull request Sep 14, 2022
Fix local cluster tests for QUIC usage (#27071)

(cherry picked from commit ce23003)

Co-authored-by: Pankaj Garg <pankaj@solana.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants