This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Feature: disable CPI setting is_executable and rent_epoch#26987
Merged
Lichtso merged 4 commits intosolana-labs:masterfrom Aug 9, 2022
Merged
Conversation
Lichtso
force-pushed
the
feature/disable_cpi_setting_executable_and_rent_epoch
branch
from
921d7a5 to
e03eab6
Compare
Lichtso
changed the title
is_executable and rent_epoch
jstarry
previously approved these changes
Aug 8, 2022
jstarry
added
the
feature-gate
Contributor
Actually, could you add tests that enforce the new behavior of ignoring changes to executable / rent_epoch? |
jstarry
approved these changes
Aug 9, 2022
Lichtso
deleted the
feature/disable_cpi_setting_executable_and_rent_epoch
branch
Lichtso
removed
the
feature-gate
Contributor
Author
|
I already opened a feature gate issue: #26988 |
Contributor
|
Yes, I saw that. Why did you remove the label? The feature-gate label was intended to make it easy to search for PRs that created or modified a feature. |
Contributor
Author
|
Oh, ok I thought it was only for the feature issues |
Lichtso
added
the
feature-gate
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Aug 17, 2022
…-labs#26987) * Adds the feature disable_cpi_setting_executable_and_rent_epoch. * Adds the feature gate for disable_cpi_setting_executable_and_rent_epoch. * Removes TEST_EXECUTABLE_LAMPORTS. * Test that is_executable and rent_epoch are ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#19762 added
is_executableandrent_epochto be deserialized in CPI. These two fields however are not deserialized at the return edge of BPF programs.Summary of Changes
Stop setting
is_executableandrent_epochin CPI after the newly added featuredisable_cpi_setting_executable_and_rent_epochis active.Feature Gate Issue: #26988